Hi Lee,
On Mon, Mar 09, 2015 at 10:47:15AM -0700, Dmitry Torokhov wrote:
> Even if bus is not hot-pluggable, the devices can be unbound from the
> driver via sysfs, so we should not be using __exit annotations on
> remove() methods. The only exception is drivers registered with
> platform_driver_probe() which specifically disables sysfs bind/unbind
> attributes.
>
> Signed-off-by: Dmitry Torokhov <[email protected]>
*ping*
Thanks.
> ---
> drivers/mfd/tps65010.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/tps65010.c b/drivers/mfd/tps65010.c
> index 743fb52..448f0a1 100644
> --- a/drivers/mfd/tps65010.c
> +++ b/drivers/mfd/tps65010.c
> @@ -515,7 +515,7 @@ static int tps65010_gpio_get(struct gpio_chip *chip,
> unsigned offset)
>
> static struct tps65010 *the_tps;
>
> -static int __exit tps65010_remove(struct i2c_client *client)
> +static int tps65010_remove(struct i2c_client *client)
> {
> struct tps65010 *tps = i2c_get_clientdata(client);
> struct tps65010_board *board = dev_get_platdata(&client->dev);
> @@ -684,7 +684,7 @@ static struct i2c_driver tps65010_driver = {
> .name = "tps65010",
> },
> .probe = tps65010_probe,
> - .remove = __exit_p(tps65010_remove),
> + .remove = tps65010_remove,
> .id_table = tps65010_id,
> };
>
> --
> 2.2.0.rc0.207.ga3a616c
>
>
> --
> Dmitry
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
