__mark_inode_dirty() always dirtied the inode against the root wb
(bdi_writeback).  The previous patches added all the infrastructure
necessary to attribute an inode against the wb of the dirtying cgroup.

This patch updates __mark_inode_dirty() so that it uses the wb
associated with the inode instead of unconditionally using the root
one.

Currently, none of the filesystems has FS_CGROUP_WRITEBACK and all
pages will keep being dirtied against the root wb.

v2: Updated for per-inode wb association.

Signed-off-by: Tejun Heo <t...@kernel.org>
Cc: Jens Axboe <ax...@kernel.dk>
Cc: Jan Kara <j...@suse.cz>
---
 fs/fs-writeback.c | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index 9f42c14..2b9c82b 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -1432,7 +1432,6 @@ static noinline void block_dump___mark_inode_dirty(struct 
inode *inode)
 void __mark_inode_dirty(struct inode *inode, int flags)
 {
        struct super_block *sb = inode->i_sb;
-       struct backing_dev_info *bdi = NULL;
        int dirtytime;
 
        trace_writeback_mark_inode_dirty(inode, flags);
@@ -1502,21 +1501,21 @@ void __mark_inode_dirty(struct inode *inode, int flags)
                 * reposition it (that would break b_dirty time-ordering).
                 */
                if (!was_dirty) {
+                       struct bdi_writeback *wb = inode_to_wb(inode);
                        bool wakeup_bdi = false;
-                       bdi = inode_to_bdi(inode);
 
                        spin_unlock(&inode->i_lock);
-                       spin_lock(&bdi->wb.list_lock);
+                       spin_lock(&wb->list_lock);
 
-                       WARN(bdi_cap_writeback_dirty(bdi) &&
-                            !test_bit(WB_registered, &bdi->wb.state),
-                            "bdi-%s not registered\n", bdi->name);
+                       WARN(bdi_cap_writeback_dirty(wb->bdi) &&
+                            !test_bit(WB_registered, &wb->state),
+                            "bdi-%s not registered\n", wb->bdi->name);
 
                        inode->dirtied_when = jiffies;
-                       wakeup_bdi = inode_wb_list_move_locked(inode, &bdi->wb,
-                                       dirtytime ? &bdi->wb.b_dirty_time :
-                                                   &bdi->wb.b_dirty);
-                       spin_unlock(&bdi->wb.list_lock);
+                       wakeup_bdi = inode_wb_list_move_locked(inode, wb,
+                                       dirtytime ? &wb->b_dirty_time :
+                                                   &wb->b_dirty);
+                       spin_unlock(&wb->list_lock);
                        trace_writeback_dirty_inode_enqueue(inode);
 
                        /*
@@ -1525,8 +1524,8 @@ void __mark_inode_dirty(struct inode *inode, int flags)
                         * to make sure background write-back happens
                         * later.
                         */
-                       if (bdi_cap_writeback_dirty(bdi) && wakeup_bdi)
-                               wb_wakeup_delayed(&bdi->wb);
+                       if (bdi_cap_writeback_dirty(wb->bdi) && wakeup_bdi)
+                               wb_wakeup_delayed(wb);
                        return;
                }
        }
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to