* 2015-04-07 20:03 GMT+06:00 Ingo Molnar <[email protected]>:
>
> Yes, you need to check how and where in the arch init code
> boot_command_line is set up in the CONFIG_CMDLINE_OVERRIDE=y case.
>
arch setup code defines builtin_cmdline and initalizes it with
CONFIG_CMDLINE, which
is 'root=/dev/sdb earlyprintk=ttyS0 loglevel=7 debug rdinit=/sbin/init
root=/dev/ram memblock=debug' string in my test. During kernel
initialization (int setup_arch),
builtin_cmdline copying to the boot_command_line if CONFIG_CMDLINE_OVERRIDE and
CONFIG_CMDLINE_BOOL are set.
I think that it is not correct to pass boot_command_line to the
setup_early_printk in
CONFIG_CMDLINE_OVERRIDE=y case. As boot_command_line will be overwritten with
builtin_cmdline.
What do you think if we'll builtin_cmdline from the
arch/x86/kernel/setup.c to the init.h to
make it visible for head_{32,64}.c and pass builtin_cmdline or
boot_command_line to
the setup_early_printk depend on CONFIG_CMDLINE_OVERRIDE?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
