On Mon, Apr 13, 2015 at 11:04:26AM +0100, Mel Gorman wrote: > On Mon, Apr 13, 2015 at 10:56:45AM +0100, Russell King - ARM Linux wrote: > > On Sun, Apr 12, 2015 at 06:21:15PM -0700, Gregory Fong wrote: > > > On Sun, Apr 12, 2015 at 06:09:13PM -0700, Gregory Fong wrote: > > > > And now we see 83 slab_reclaimable + 846 slab_unreclaimable adds up > > > > correctly to the total of 929. > > > > > > > > The patch below will end up with the correct count. > > > > > > > > > > Sorry, messed up the patch formatting. Here it is fixed: > > > > So now the question is: do we fix this, or do we use the generic version? > > Given that the total number of slab pages can be easily deduced from the > > generic statistics, do we need to modify the generic version to print an > > additional line with this? > > Whatever ARM decides, I do not think the generic version needs to do > a PFN walk to recaluate the SLAB statistics. The slab_reclaimable and > slab_unreclaimable stats based on the vmstat counters is sufficient.
Yes, I agree. My feeling is we just switch to the generic version and be done with it. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
