On 14.04, Honggang LI wrote: > On Tue, Apr 14, 2015 at 04:26:27PM +0100, Patrick McHardy wrote: > > > > That is completely useless. vlan (=netdev_priv) can not be NULL as > > netdev_priv() never returns NULL and vlan->lowerdev is always valid > > because a macvlan wouldn't make much sense otherwise. > > OK, please drop this patch.
Well, the fact that netdev_priv never return NULL implies all your patches need to be redone. And I suggest you check whether this condition can actually happen. Just because it can in one driver says nothing at all about others. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/