Hello Dmitry, On Wednesday, April 15, 2015 18:35 BST, Dmitry Torokhov <[email protected]> wrote: > On Wed, Apr 15, 2015 at 05:58:04PM +0200, Javier Martinez Canillas wrote: > > > > This is an unrelated cleanup so probably should had been a separate patch? > > Fair enough. > > -- > Dmitry > > > Input: atmel_mxt_ts - use BIT() macro when reporting button state > > From: Dmitry Torokhov <[email protected]> > > This makes the intent a tad more clear. > > Signed-off-by: Dmitry Torokhov <[email protected]> > --- > drivers/input/touchscreen/atmel_mxt_ts.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c > b/drivers/input/touchscreen/atmel_mxt_ts.c > index 0d87ffc..0dcd455 100644 > --- a/drivers/input/touchscreen/atmel_mxt_ts.c > +++ b/drivers/input/touchscreen/atmel_mxt_ts.c > @@ -726,15 +726,15 @@ static void mxt_input_button(struct mxt_data *data, u8 > *message) > { > struct input_dev *input = data->input_dev; > const struct mxt_platform_data *pdata = data->pdata; > - bool button; > int i; > > - /* Active-low switch */ > for (i = 0; i < pdata->t19_num_keys; i++) { > if (pdata->t19_keymap[i] == KEY_RESERVED) > continue; > - button = !(message[1] & (1 << i)); > - input_report_key(input, pdata->t19_keymap[i], button); > + > + /* Active-low switch */ > + input_report_key(input, pdata->t19_keymap[i], > + !(message[1] & BIT(i))); > } > } >
Patch looks good to me, thanks a lot for splitting the changes and sorry for the nitpicking. Reviewed-by: Javier Martinez Canillas <[email protected]> Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
