On Wed, Apr 22, 2015 at 09:44:52AM -0400, Doug Ledford wrote: > On Tue, 2015-04-21 at 14:50 -0700, Luis R. Rodriguez wrote: > > From: "Luis R. Rodriguez" <[email protected]> > > > > There is no good reason not to, we eventually delete it as well. > > > > Cc: Toshi Kani <[email protected]> > > Cc: Suresh Siddha <[email protected]> > > Cc: Ingo Molnar <[email protected]> > > Cc: Thomas Gleixner <[email protected]> > > Cc: Juergen Gross <[email protected]> > > Cc: Daniel Vetter <[email protected]> > > Cc: Andy Lutomirski <[email protected]> > > Cc: Dave Airlie <[email protected]> > > Cc: Antonino Daplas <[email protected]> > > Cc: Jean-Christophe Plagniol-Villard <[email protected]> > > Cc: Tomi Valkeinen <[email protected]> > > Cc: Mike Marciniszyn <[email protected]> > > Cc: Roland Dreier <[email protected]> > > Cc: Sean Hefty <[email protected]> > > Cc: Hal Rosenstock <[email protected]> > > Cc: [email protected] > > Cc: [email protected] > > Cc: [email protected] > > Signed-off-by: Luis R. Rodriguez <[email protected]> > > --- > > drivers/infiniband/hw/qib/qib_wc_x86_64.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/infiniband/hw/qib/qib_wc_x86_64.c > > b/drivers/infiniband/hw/qib/qib_wc_x86_64.c > > index 81b225f..fe0850a 100644 > > --- a/drivers/infiniband/hw/qib/qib_wc_x86_64.c > > +++ b/drivers/infiniband/hw/qib/qib_wc_x86_64.c > > @@ -118,7 +118,7 @@ int qib_enable_wc(struct qib_devdata *dd) > > if (!ret) { > > int cookie; > > > > - cookie = mtrr_add(pioaddr, piolen, MTRR_TYPE_WRCOMB, 0); > > + cookie = mtrr_add(pioaddr, piolen, MTRR_TYPE_WRCOMB, 1); > > if (cookie < 0) { > > { > > qib_devinfo(dd->pcidev, > > Skip this patch please. You remove this line entirely in your next > patch, so this becomes a single kernel out of all possible bisectable > kernels with this accounting enabled, and then the very next kernel does > away with it.
No, the next patch uses accounting enabled as well, it also makes somse other changes. This change is done in order to add accounting to match the grammar used by arch_phys_wc_add() so it is in fact an atomic comittiable and highly recommmended bisectable commit to be present. > It makes no sense to have a single outlying bisectable > kernel like that. This is an atomic difference worth keeping record of. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
