>> -DEFINE_EVENT_PRINT(mm_page, mm_page_pcpu_drain, >> +TRACE_EVENT_CONDITION(mm_page_pcpu_drain, >> >> TP_PROTO(struct page *page, unsigned int order, int migratetype), >> >> TP_ARGS(page, order, migratetype), >> >> + TP_CONDITION(cpu_online(smp_processor_id())), >> + >> + TP_STRUCT__entry( >> + __field( unsigned long, pfn ) >> + __field( unsigned int, order ) >> + __field( int, migratetype ) >> + ), >> + >> + TP_fast_assign( >> + __entry->pfn = page ? page_to_pfn(page) : -1UL; >> + __entry->order = order; >> + __entry->migratetype = migratetype; >> + ), >> + > > What was the need to do the above changes besides adding TP_CONDITION ? >
IIUC there is no existing macro which can both add a condition and override printk format, hence the fall back to TRACE_EVENT_CONDITION. Thanks, Shreyas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
