On 05/06/2015 02:39 AM, Stephen Boyd wrote: > This list doesn't look to be used. Let's remove it and any > associated code that would be manipulating this list. This also > silences this error: > > drivers/clk/bcm/clk-kona-setup.c:24:1: warning: symbol 'ccu_list' was not > declared. Should it be static?
It should have been static. And I thought it would be used but it's not, so I agree, it's not serving any real purpose. Reviewed-by: Alex Elder <[email protected]> > Cc: Alex Elder <[email protected]> > Cc: Tim Kryger <[email protected]> > Signed-off-by: Stephen Boyd <[email protected]> > --- > drivers/clk/bcm/clk-kona-setup.c | 4 ---- > drivers/clk/bcm/clk-kona.h | 2 -- > 2 files changed, 6 deletions(-) > > diff --git a/drivers/clk/bcm/clk-kona-setup.c > b/drivers/clk/bcm/clk-kona-setup.c > index e5aededdd322..deaa7f962b84 100644 > --- a/drivers/clk/bcm/clk-kona-setup.c > +++ b/drivers/clk/bcm/clk-kona-setup.c > @@ -21,8 +21,6 @@ > #define selector_clear_exists(sel) ((sel)->width = 0) > #define trigger_clear_exists(trig) FLAG_CLEAR(trig, TRIG, EXISTS) > > -LIST_HEAD(ccu_list); /* The list of set up CCUs */ > - > /* Validity checking */ > > static bool ccu_data_offsets_valid(struct ccu_data *ccu) > @@ -773,7 +771,6 @@ static void kona_ccu_teardown(struct ccu_data *ccu) > > of_clk_del_provider(ccu->node); /* safe if never added */ > ccu_clks_teardown(ccu); > - list_del(&ccu->links); > of_node_put(ccu->node); > ccu->node = NULL; > iounmap(ccu->base); > @@ -847,7 +844,6 @@ void __init kona_dt_ccu_setup(struct ccu_data *ccu, > goto out_err; > } > ccu->node = of_node_get(node); > - list_add_tail(&ccu->links, &ccu_list); > > /* > * Set up each defined kona clock and save the result in > diff --git a/drivers/clk/bcm/clk-kona.h b/drivers/clk/bcm/clk-kona.h > index 6849a64baf6d..906576ec97b6 100644 > --- a/drivers/clk/bcm/clk-kona.h > +++ b/drivers/clk/bcm/clk-kona.h > @@ -480,7 +480,6 @@ struct ccu_data { > spinlock_t lock; /* serialization lock */ > bool write_enabled; /* write access is currently enabled */ > struct ccu_policy policy; > - struct list_head links; /* for ccu_list */ > struct device_node *node; > struct clk_onecell_data clk_data; > const char *name; > @@ -492,7 +491,6 @@ struct ccu_data { > #define KONA_CCU_COMMON(_prefix, _name, _ccuname) \ > .name = #_name "_ccu", \ > .lock = __SPIN_LOCK_UNLOCKED(_name ## _ccu_data.lock), \ > - .links = LIST_HEAD_INIT(_name ## _ccu_data.links), \ > .clk_data = { \ > .clk_num = _prefix ## _ ## _ccuname ## _CCU_CLOCK_COUNT, \ > } > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
