On 05/06/2015 08:49 AM, Tyler Baker wrote: > Hi Shuah, > > On 21 April 2015 at 15:49, Tyler Baker <[email protected]> wrote: >> This patch set fixes various issues observed when cross building and >> installing selftests. >> >> As I began investigating improving the test output format, I performed an >> audit of the current tests to ensure all tests were able to execute on >> various >> target architectures. I found that some tests did not install their binaries >> and others required directories to be installed to execute properly. There >> were also cases in which tests were being installed when they were never >> built. >> With this series applied all tests compile when appropriate and install their >> output properly. >> >> I have tested this series by building, installing and deploying all selftests >> to x86, arm and arm64 targets. >> >> Changes v3 -> v4: >> * Planning to send a followup series to address the lib.mk issue so I've >> dropped the breakpoints and x86 installation workaround. >> * x86: Removed redundant else logic block. >> * Applied Andy Lutomirski's ACK to patches 4 and 5. >> * Rebased onto next-20150421. > > I believe all comments have been addressed, is there anything else you > would like to see? > >> >> Changes v2 -> v3: >> * 5/8: Removed duplicate all_32. >> * 6/8: Ensure the default rule is all in every case. >> * 6/8: Fixed commit message wording for better clarity. >> * Applied Michael Ellerman's ACK to patches 1-4, and 8 as they have not >> changed. >> * Rebased onto next-20150420. >> >> Changes v1 -> v2: >> * Have no dependency on all when CROSS_COMPILE is set. (Andy Lutomirski) >> * Added Andy on CC for all x86 test patches. >> * Split up the x86 patches for better clarity. >> * Rebased onto next-20150415. >> >> This series is based on next-20150421. >> >> Tyler Baker (7): >> selftests: copy TEST_DIRS to INSTALL_PATH >> selftests/ftrace: install test.d >> selftests/kdbus: install kdbus-test >> selftest/x86: build both bitnesses >> selftest/x86: have no dependency on all when cross building >> selftests/x86: install tests >> selftests/exec: do not install subdir as it is already created >> >> tools/testing/selftests/exec/Makefile | 2 +- >> tools/testing/selftests/ftrace/Makefile | 1 + >> tools/testing/selftests/kdbus/Makefile | 2 ++ >> tools/testing/selftests/lib.mk | 3 +++ >> tools/testing/selftests/x86/Makefile | 15 ++++++++++++--- >> 5 files changed, 19 insertions(+), 4 deletions(-) >> >> -- >> 2.1.4 >> >
Patches are good. I will be applying these to linux-kselftest next in a day or two for 4.2 Thanks for fixing these issues. -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) [email protected] | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
