On 2015/05/09 18:55, He Kuang wrote: > Indicate to check variable location range in error message when we got > failed to find the variable. > > Before this patch: > > $ perf probe --add 'generic_perform_write+118 bytes' > Failed to find the location of bytes at this address. > Perhaps, it has been optimized out. > Error: Failed to add events. > > After this patch: > $ perf probe --add 'generic_perform_write+118 bytes' > Failed to find the location of bytes at this address. > Perhaps, it has been optimized out. > Use -V with --range option to show variable location range. > Error: Failed to add events.
OK, this helps users :) Acked-by: Masami Hiramatsu <masami.hiramatsu...@hitachi.com> Thank you, > > Signed-off-by: He Kuang <heku...@huawei.com> > --- > tools/perf/util/probe-finder.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c > index 30a1a1b..2b91323 100644 > --- a/tools/perf/util/probe-finder.c > +++ b/tools/perf/util/probe-finder.c > @@ -532,7 +532,9 @@ static int convert_variable(Dwarf_Die *vr_die, struct > probe_finder *pf) > &pf->sp_die, pf->tvar); > if (ret == -ENOENT || ret == -EINVAL) > pr_err("Failed to find the location of %s at this address.\n" > - " Perhaps, it has been optimized out.\n", pf->pvar->var); > + " Perhaps, it has been optimized out.\n" > + " Use -V with --range option to show variable location > range.\n", > + pf->pvar->var); > else if (ret == -ENOTSUP) > pr_err("Sorry, we don't support this variable location yet.\n"); > else if (ret == 0 && pf->pvar->field) { > -- Masami HIRAMATSU Linux Technology Research Center, System Productivity Research Dept. Center for Technology Innovation - Systems Engineering Hitachi, Ltd., Research & Development Group E-mail: masami.hiramatsu...@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/