On Mon, May 4, 2015 at 5:10 PM, Johan Hovold <[email protected]> wrote:
> Drivers should call gpiochip_lock_as_irq (which prevents the pin > direction from being changed) in their irq_request_resources callbacks > but some drivers currently fail to do so. > > Instead a second, explicit and often redundant call to lock-as-irq is > made by the sysfs-interface implementation after an irq has been > requested. > > Move the explicit call before the irq-request to match the unlock done > after the irq is later released. Note that this also fixes an irq leak, > should the explicit call ever have failed. > > Also add a comment about removing the redundant call once the broken > drivers have been fixed. > > Signed-off-by: Johan Hovold <[email protected]> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
