On Thu, 14 May 2015, Richard Fitzgerald wrote: > On Thu, May 14, 2015 at 11:08:33AM +0100, Lee Jones wrote: > > On Thu, 14 May 2015, Richard Fitzgerald wrote: > > > > > Signed-off-by: Richard Fitzgerald <[email protected]> > > > --- > > > > This is v4, so where's the change log? > > > > I looked though my own history of the patch and I see that I already > > Acked v3, so I'm pretty unsure what's happening. > > > > I'm unsure too. Last I have from you on the v3 of this patch is your > question of whether it's orthogonal enough for you to just take it. You've > acked it, but not said that you've applied it and your for-mfd-next tree > doesn't contain it yet so I assumed that you haven't applied it yet. > Therefore... I've done v4 which fixes the incorrect makefile conditional > that was in the v3 patch.
Right, so unless there are major changes, the Ack should be applied to this patch. If there are changes, a change-log is always helpful. Without one I have to re-review the whole 2k lines, which for obvious reasons I'd like to avoid. > If you are busy applying the v3 patch and want to take that as-is I can > do a separate bugfix patch on top of v3 to fix the makefile. I haven't applied the patch, only Acked it. > > > drivers/mfd/Kconfig | 6 + > > > drivers/mfd/Makefile | 3 + > > > drivers/mfd/arizona-core.c | 105 ++- > > > drivers/mfd/arizona-i2c.c | 8 + > > > drivers/mfd/arizona-irq.c | 9 + > > > drivers/mfd/arizona.h | 5 + > > > drivers/mfd/wm8998-tables.c | 1592 > > > +++++++++++++++++++++++++++++++++ > > > include/linux/mfd/arizona/core.h | 3 + > > > include/linux/mfd/arizona/pdata.h | 2 + > > > include/linux/mfd/arizona/registers.h | 220 +++++ > > > 10 files changed, 1945 insertions(+), 8 deletions(-) > > > create mode 100644 drivers/mfd/wm8998-tables.c > > > > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > > index 048f5bf..d2e549b 100644 > > > --- a/drivers/mfd/Kconfig > > > +++ b/drivers/mfd/Kconfig > > > @@ -1359,6 +1359,12 @@ config MFD_WM8997 > > > help > > > Support for Wolfson Microelectronics WM8997 low power audio SoC > > > > > > +config MFD_WM8998 > > > + bool "Wolfson Microelectronics WM8998" > > > + depends on MFD_ARIZONA > > > + help > > > + Support for Wolfson Microelectronics WM8998 low power audio SoC > > > + > > > config MFD_WM8400 > > > bool "Wolfson Microelectronics WM8400" > > > select MFD_CORE > > > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > > > index ca6d184..d244afc 100644 > > > --- a/drivers/mfd/Makefile > > > +++ b/drivers/mfd/Makefile > > > @@ -50,6 +50,9 @@ endif > > > ifneq ($(CONFIG_MFD_WM8997),n) > > > obj-$(CONFIG_MFD_ARIZONA) += wm8997-tables.o > > > endif > > > +ifeq ($(CONFIG_MFD_WM8998),y) > > > +obj-$(CONFIG_MFD_ARIZONA) += wm8998-tables.o > > > +endif -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
