Hi Matthias,
2015-05-16 18:17 GMT+09:00 Matthias Brugger <[email protected]>: >> +/* >> + * The register map is slightly different from that of 8250. >> + * IO callbacks must be overridden for correct access to FCR, LCR, and MCR. >> + */ >> +static unsigned int uniphier_serial_in(struct uart_port *p, int offset) >> +{ >> + int valshift = 0; >> + >> + switch (offset) { >> + case UART_LCR: >> + valshift = 8; > > Please use a define for the value. Something like UNIPHIER_UART_LCR_SHIFT > maybe. > Will do in v2. Thank you! -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
