There is already a rule misc/of_table.cocci for the of_device_id case. I think it would be better to extend that.
Also, rather than making an identifier name, it would be more efficient to put struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = ... The Coccinelle will only work on files that contain those identifiers. julia On Mon, 18 May 2015, Daniel Granat wrote: > Signed-off-by: Daniel Granat <[email protected]> > --- > scripts/coccinelle/misc/of_platform.cocci | 65 > +++++++++++++++++++++++++++++++ > 1 file changed, 65 insertions(+) > create mode 100644 scripts/coccinelle/misc/of_platform.cocci > > diff --git a/scripts/coccinelle/misc/of_platform.cocci > b/scripts/coccinelle/misc/of_platform.cocci > new file mode 100644 > index 0000000..02c6195 > --- /dev/null > +++ b/scripts/coccinelle/misc/of_platform.cocci > @@ -0,0 +1,65 @@ > +/// Make sure that tables are NULL terminated > +// > +// Keywords: _device_id > +// Confidence: Medium > +// Options: --include-headers > + > +virtual report > +virtual patch > + > +@r depends on report@ > +position p1; > +identifier var, arr; > +identifier name = {of_device_id, i2c_device_id, platform_device_id}; > +expression E; > +@@ > + > +( > +struct name arr[] = { > + ..., > + { > + .var = E, > + } > + @p1 > +}; > +| > +struct name arr[] = { > + ..., > + { ..., var, ... }, > + @p1 > +}; > +) > + > +@script:python depends on report@ > +p1 << r.p1; > +arr << r.arr; > +@@ > + > +msg = "%s is not NULL terminated at line %s" % (arr, p1[0].line) > +coccilib.report.print_report(p1[0],msg) > + > +@p depends on patch@ > +position p1; > +identifier var, arr; > +identifier name = {of_device_id, i2c_device_id, platform_device_id}; > +expression E; > +@@ > + > +( > +struct name arr[] = { > + ..., > + { > + .var = E, > +- } > + @p1 > ++ }, > ++ {}, > +}; > +| > +struct name arr[] = { > + ..., > + { ..., var, ... }, > + @p1 > ++ {}, > +}; > +) > -- > 1.9.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
