On Wed, May 27, 2015 at 08:20:12PM +0900, Sergey Senozhatsky wrote: > Improvement idea by Marcin Jabrzyk. > > comp_algorithm_store() silently accepts any supplied algorithm > name, because zram performs algorithm availability check later, > during the device configuration phase in disksize_store() and > emits the following error: > "zram: Cannot initialise %s compressing backend" > > this error line is somewhat generic and, besides, can indicate > a failed attempt to allocate compression backend's working > buffers. > > add algorithm availability check to comp_algorithm_store(): > > echo lzz > /sys/block/zram0/comp_algorithm > -bash: echo: write error: Invalid argument > > Signed-off-by: Sergey Senozhatsky <[email protected]> > Reported-by: Marcin Jabrzyk <[email protected]> Acked-by: Minchan Kim <[email protected]>
Thanks. -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
