On Thu, 2015-05-28 at 10:14 +0300, Dan Carpenter wrote:
> On Wed, May 27, 2015 at 01:30:08PM -0700, Joe Perches wrote:
> > Perhaps all of the uses like:
> >     goto <foo>;
> > <foo>:
> > 
> > could be modified.  There are ~150 in the kernel.
> 
> Joe, these are a kind of style.  You're just directing a newbie into a
> hornets nest.  Laurant, don't do listen to Joe unless you like getting
> flamed.

Hey Dan.

I didn't direct anyone to do anything, but that's
why I added Julia to cc's.

Anyway, I think these are very equivalent style to
the repeated:

        ret = foo();
        if (ret < 0)
                return ret;
...
        ret = bar();
        if (ret < 0)
                return ret;

        return ret;

and people seem to prefer changing those.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to