On Thu, May 21, 2015 at 1:21 PM, Geert Uytterhoeven
<[email protected]> wrote:
> If an interrupt controller doesn't support wake-up configuration,
> irq_set_irq_wake() returns an error code. Then any subsequent call
> trying to deconfigure wake-up will cause an imbalance, and a warning
> will be printed:
>
> WARNING: CPU: 1 PID: 1341 at kernel/irq/manage.c:540
> irq_set_irq_wake+0x9c/0xf8()
> Unbalanced IRQ 26 wake disable
>
> To fix this, refrain from any further parent interrupt controller
> (de)configuration if irq_set_irq_wake() failed.
>
> Alternative fixes would be:
> - calling "gic_set_irqchip_flags(IRQCHIP_SKIP_SET_WAKE)" from the
> platform code,
> - setting "gic_chip.flags = IRQCHIP_SKIP_SET_WAKE" in the GIC driver
> code,
> but these were withheld as the GIC hardware doesn't really support
> wake-up interrupts.
>
> Fixes: ab82fa7da4dce5c7 ("gpio: rcar: Prevent module clock disable when
> wake-up is enabled")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> v2:
> - Reworded patch description,
> - Moved alternatives into the patch description.
Patch applied.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
