On Tue, Jun 02, 2015 at 10:12:04AM -0700, Sukadev Bhattiprolu wrote: > From: Andi Kleen <[email protected]> > > The Intel events use a dot to separate event name and unit mask. > Allow dot in names in the scanner, and remove special handling > of dot as EOF. Also remove the hack in jevents to replace dot > with underscore. This way dotted events can be specified > directly by the user. > > I'm not fully sure this change to the scanner is correct > (what was the dot special case good for?), but I haven't > found anything that breaks with it so far at least.
can't see anything either Robert, does it ring a bell? seems like you introduced it ;-) thanks, jirka > > V2: Add the dot to name too, to handle events outside cpu// > Acked-by: Namhyung Kim <[email protected]> > Signed-off-by: Andi Kleen <[email protected]> > Signed-off-by: Sukadev Bhattiprolu <[email protected]> > --- > tools/perf/util/parse-events.l | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l > index 09e738f..13cef3c 100644 > --- a/tools/perf/util/parse-events.l > +++ b/tools/perf/util/parse-events.l > @@ -119,8 +119,8 @@ event [^,{}/]+ > num_dec [0-9]+ > num_hex 0x[a-fA-F0-9]+ > num_raw_hex [a-fA-F0-9]+ > -name [a-zA-Z_*?][a-zA-Z0-9_*?]* > -name_minus [a-zA-Z_*?][a-zA-Z0-9\-_*?]* > +name [a-zA-Z_*?][a-zA-Z0-9_*?.]* > +name_minus [a-zA-Z_*?][a-zA-Z0-9\-_*?.]* > /* If you add a modifier you need to update check_modifier() */ > modifier_event [ukhpGHSDI]+ > modifier_bp [rwx]{1,3} > @@ -165,7 +165,6 @@ modifier_bp [rwx]{1,3} > return PE_EVENT_NAME; > } > > -. | > <<EOF>> { > BEGIN(INITIAL); > REWIND(0); > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
