On Saturday 30 July 2005 18:02, Jeff Dike wrote: > On Thu, Jul 28, 2005 at 08:56:53PM +0200, [EMAIL PROTECTED] wrote: > > As obvious, a "core code nice cleanup" is not a "stability-friendly > > patch" so usual care applies.
> These look reasonable, as they are what we discussed in Ottawa. > I'll put them in my tree and see if I see any problems. I would > suggest sending these in early after 2.6.13 if they seem OK. I've discovered that we're not the only one to miss dirty / accessed "hardware" bits: see include/asm-alpha/pgtable.h (they don't have the accessed bit). So maybe we could drop the "fault-on-access" thing. Also, note the comment before handle_pte_fault: /* * These routines also need to handle stuff like marking pages dirty * and/or accessed for architectures that don't do it in hardware (most * RISC architectures). The early dirtying is also good on the i386. */ I'm not able to find where we clean the dirty bit on a pte, however it's not only done by pte_mkclean, there are some macros like ptep_clear... in asm-generic/pgtable.h -- Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!". Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894) http://www.user-mode-linux.org/~blaisorblade ___________________________________ Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB http://mail.yahoo.it - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
