[corrected akpm's address] On Fri, Aug 12, 2005 at 12:02:03PM -0700, John Ronciak wrote: > Sorry this reply was to go to the whole list but only made it to Matt. > > The e1000_intr() routine already calls e1000_clean_tx_irq(). So > what's the point of this patch? Am I missing something?
Here is Steven's original analysis: http://lkml.org/lkml/2005/8/5/116 It looked plausible, but I didn't dig much deeper. > > Index: l/drivers/net/e1000/e1000_main.c > > =================================================================== > > --- l.orig/drivers/net/e1000/e1000_main.c 2005-08-06 > > 17:36:32.000000000 -0500 > > +++ l/drivers/net/e1000/e1000_main.c 2005-08-06 17:55:01.000000000 -0500 > > @@ -3789,6 +3789,7 @@ e1000_netpoll(struct net_device *netdev) > > struct e1000_adapter *adapter = netdev_priv(netdev); > > disable_irq(adapter->pdev->irq); > > e1000_intr(adapter->pdev->irq, netdev, NULL); > > + e1000_clean_tx_irq(adapter); > > enable_irq(adapter->pdev->irq); > > } > > #endif -- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
