On Thu, 2015-06-04 at 23:37 +0100, Al Viro wrote: > On Thu, Jun 04, 2015 at 03:56:07AM -0700, Joe Perches wrote: > > Seems sensible, but the name maybe could be be more > > explicit as strreplace seems like it should more like > > a string substitution rather than a char substitution. > > > > Maybe strsubstchr or something like it (strtranschr?) > > Why not go the full monty and call it strtrtsstrrrtst(), with > strtrtssstrrtst() doing almost, but not quite the same thing?
Presumably the extra r is for reverse and the extra s in for insensitive, just because... Naming does matter. Consistency too. And for the consistency bit, the char arguments should probably be int. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
