On 15-06-05 10:42 AM, Chris Metcalf wrote: > On 06/05/2015 10:36 AM, Paul Gortmaker wrote: >> Pending header cleanups will reveal this file is using the >> init.h content implicitly with the following fail: >> >> arch/tile/kernel/usb.c:69:1: warning: data definition has no type or storage >> class [enabled by default] >> arch/tile/kernel/usb.c:69:1: error: type defaults to 'int' in declaration of >> 'arch_initcall' >> arch/tile/kernel/usb.c:69:1: warning: parameter names (without types) in >> function declaration [enabled by default] >> arch/tile/kernel/usb.c:62:19: warning: 'tilegx_usb_init' defined but not used >> >> Explicitly add init.h to get arch_initcall and avoid this. >> >> Reported-by: kbuild test robot<[email protected]> >> Cc: Chris Metcalf<[email protected]> >> Signed-off-by: Paul Gortmaker<[email protected]> >> --- >> >> [adding this to the header move series of commits; see >> >> https://lkml.kernel.org/r/[email protected] >> for original series posting. ] >> >> arch/tile/kernel/usb.c | 1 + >> 1 file changed, 1 insertion(+) > > Acked-by: Chris Metcalf <[email protected]> > > or I'm happy to take it into the tile tree if you'd rather I did.
Thanks, I'll carry it since I'd risk introducing bisection failures if my header changes go in without this being present 1st. Paul. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
