On Tue, 09 Jun 2015, Mark Brown wrote: > On Tue, Jun 09, 2015 at 08:03:47AM +0100, Lee Jones wrote: > > > Admittedly this is an extreme example, but I do consider: > > > init_data = of_get_regulator_init_data(<blah>); > > if (init_data) > > return -ENOMEM; > > > ... neater than: > > > config.init_data = of_get_regulator_init_data(<blah>); > > if (!config.init_data) > > return -ENOMEM; > > Oh, I see. I pretty much see things the other way for things where the > temporary has no other users.
I don't feel passionate enough about it to contest. Skip this patch then. Are you okay to continue the review? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
