On Tue, 9 Jun 2015 01:26:54 +0200 Rasmus Villemoes <[email protected]> wrote:
> There's no point in starting over when we meet a '/'. This also > eliminates a stack variable and a little .text. > > Signed-off-by: Rasmus Villemoes <[email protected]> > --- > v2: no changes. > > drivers/md/md.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/md/md.c b/drivers/md/md.c > index 27506302eb7a..2ea2f28551c5 100644 > --- a/drivers/md/md.c > +++ b/drivers/md/md.c > @@ -2024,7 +2024,6 @@ static int bind_rdev_to_array(struct md_rdev > *rdev, struct mddev *mddev) { > char b[BDEVNAME_SIZE]; > struct kobject *ko; > - char *s; > int err; > > /* prevent duplicates */ > @@ -2070,8 +2069,7 @@ static int bind_rdev_to_array(struct md_rdev > *rdev, struct mddev *mddev) return -EBUSY; > } > bdevname(rdev->bdev,b); > - while ( (s=strchr(b, '/')) != NULL) > - *s = '!'; > + strreplace(b, '/', '!'); > > rdev->mddev = mddev; > printk(KERN_INFO "md: bind<%s>\n", b); Acked-by: NeilBrown <[email protected]> I'm happy for Andrew to merge this. Thanks, NeilBrown -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
