Just a nit. On Thu, 2015-06-11 at 14:32 +0800, yuantian.t...@freescale.com wrote: > --- /dev/null > +++ b/arch/powerpc/sysdev/fsl_rcpm.c
> +int fsl_rcpm_init(void) This is used only through early_initcall(). I took the cargo cult approach of looking at the other uses of early_initcall() in arch/powerpc/. That approach tells me this function could be static and marked as __init. Would that work here too? > +{ > + [...] > +} > + > +/* need to call this before SMP init */ > +early_initcall(fsl_rcpm_init); Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/