On Tue, Jun 16, 2015 at 11:17:53AM -0700, Kevin Hilman wrote: > Sascha Hauer <[email protected]> writes: > > > This adds the SCPSYS device node to the MT8173 dtsi file. > > > > Signed-off-by: Sascha Hauer <[email protected]> > > --- > > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > index 924fdb6..12430f0 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > @@ -125,6 +125,16 @@ > > <GIC_SPI 147 > > IRQ_TYPE_LEVEL_HIGH>; > > }; > > > > + scpsys: scpsys@10006000 { > > + compatible = "mediatek,mt8173-scpsys"; > > + #power-domain-cells = <1>; > > + reg = <0 0x10006000 0 0x1000>; > > + clocks = <&clk26m>, > > + <&topckgen CLK_TOP_MM_SEL>; > > Neither your binding doc (nor the generic one) mentions these clock > properties or what they are used for. They appear to define a clock > that must be enabled in order to for the power domain to be on.
Ok, will add documentation for this. > > Also the order here seems rather important and probably needs > documenting in the binding (e.g. the clk_id order is hard-coded in the > driver.) The order is not important, the clock-names property defines which clock is which. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
