Commit-ID:  502819c5f35ef44eb7151fb85cd883c5b76b506d
Gitweb:     http://git.kernel.org/tip/502819c5f35ef44eb7151fb85cd883c5b76b506d
Author:     Jiri Olsa <[email protected]>
AuthorDate: Mon, 22 Jun 2015 14:50:50 +0200
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 22 Jun 2015 11:21:57 -0300

perf tests: Add testing for Makefile.perf

Currently we test only builds through top level Makefile, but seems like
there's a bunch of users using Makefile.perf directly.

Changing the make suite to be run for Makefile.perf as well.  It takes
now considerable amount of time, but hopefully we catch more issues.

Also fixing the output indentation for make_kernelsrc and
make_kernelsrc_tools tests.

Signed-off-by: Jiri Olsa <[email protected]>
Cc: Adrian Hunter <[email protected]>
Cc: Andi Kleen <[email protected]>
Cc: David Ahern <[email protected]>
Cc: Lukas Wunner <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Stephane Eranian <[email protected]>
Link: 
http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
 tools/perf/tests/make | 23 ++++++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)

diff --git a/tools/perf/tests/make b/tools/perf/tests/make
index 65280d2..bfe1962da 100644
--- a/tools/perf/tests/make
+++ b/tools/perf/tests/make
@@ -1,5 +1,16 @@
+ifndef MK
+ifeq ($(MAKECMDGOALS),)
+# no target specified, trigger the whole suite
+all:
+       @echo "Testing Makefile";      $(MAKE) -sf tests/make MK=Makefile
+       @echo "Testing Makefile.perf"; $(MAKE) -sf tests/make MK=Makefile.perf
+else
+# run only specific test over 'Makefile'
+%:
+       @echo "Testing Makefile";      $(MAKE) -sf tests/make MK=Makefile $@
+endif
+else
 PERF := .
-MK   := Makefile
 
 include config/Makefile.arch
 
@@ -57,7 +68,12 @@ make_minimal        += NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1
 
 # $(run) contains all available tests
 run := make_pure
+# Targets 'clean all' can be run together only through top level
+# Makefile because we detect clean target in Makefile.perf and
+# disable features detection
+ifeq ($(MK),Makefile)
 run += make_clean_all
+endif
 run += make_python_perf_so
 run += make_debug
 run += make_no_libperl
@@ -226,13 +242,13 @@ tarpkg:
        ( eval $$cmd ) >> $@ 2>&1
 
 make_kernelsrc:
-       @echo " - make -C <kernelsrc> tools/perf"
+       @echo "- make -C <kernelsrc> tools/perf"
        $(call clean); \
        (make -C ../.. tools/perf) > $@ 2>&1 && \
        test -x perf && rm -f $@ || (cat $@ ; false)
 
 make_kernelsrc_tools:
-       @echo " - make -C <kernelsrc>/tools perf"
+       @echo "- make -C <kernelsrc>/tools perf"
        $(call clean); \
        (make -C ../../tools perf) > $@ 2>&1 && \
        test -x perf && rm -f $@ || (cat $@ ; false)
@@ -244,3 +260,4 @@ out: $(run_O)
        @echo OK
 
 .PHONY: all $(run) $(run_O) tarpkg clean
+endif # ifndef MK
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to