On Thu, Aug 18, 2005 at 02:20:23PM -0700, Joel Becker wrote:
> On Thu, Aug 18, 2005 at 02:17:49PM -0700, Joel Becker wrote:
> > On Thu, Aug 18, 2005 at 02:26:02PM +0800, David Teigland wrote:
> > > In the dlm I use config_group_find_obj() which isn't exported.
> >
> > Did you notice the /* XXX Locking */? Let me go see how you use
> > it, if it is the best way, we'll need to revisit the function and be
> > sure it's happy.
>
> Yeah, your usage is unsafe, but the fault lies with find_obj().
> Needs fixing.
And you copied the same issue into get_comm(). When navigating
cg_children (or any part of the object tree), you need to be holding the
subsystem semaphore. Someone could race with mkdir/rmdir.
Joel
--
"Senator let's be sincere,
As much as you can."
http://www.jlbec.org/
[EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
