Hi On Thu, Jul 2, 2015 at 7:47 PM, Sergei Zviagintsev <[email protected]> wrote: > Hi Djalal, > > On Thu, Jul 02, 2015 at 03:13:41PM +0100, Djalal Harouni wrote: > [...] >> > My journey with this piece of code began from spotting and immediately >> > "fixing" the overflow issue :) Then I decided to dig into the >> > out-of-tree repo to find the origin of this line. What I found were >> > commits af8e2f750985 and ac5c385cc67a in which Djalal "fixed" it as >> > well, but then reverted back to the original code. >> > >> > Surely we can drop this explanation, but if one of kdbus maintainers >> > experienced difficulties in understanding this piece of code, wouldn't >> > one who sees this code in the first time have the same issues? >> Yes there was lot of work in this area to make sure that the quota >> accounting is correct! the previous commits the one that tried to clean >> things up and the revert were both correct :-) , > > I cannot agree that commit af8e2f750985 in out-of-tree repo was correct.
Exactly, that's why the commit got reverted. The U32_MAX check is *not* about overflows of pool-memory, but rather about overflows in quota-accounting. Thanks David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
