Viresh Kumar <[email protected]> writes: > Hi Robert, > > On 04-07-15, 17:42, Robert Jarzmik wrote: >> > + /* initializing, released, or preparing for suspend */ >> > + timer_writel(timer_readl(OIER) & ~OIER_E0, OIER); >> > + timer_writel(OSSR_M0, OSSR); >> > + return 0; >> For consistency, please leave an empty line before that return statement. > > Its already applied by Daniel now, and the change is too trivial to > request for an update to his tree. Maybe we should leave it as is for > now. If it's applied it's indeed too late.
>> > + .set_state_shutdown = pxa_osmr0_shutdown, >> > + .set_state_oneshot = pxa_osmr0_shutdown, >> A bit weird to have a "set_state_oneshot" function to point to a function >> called >> "X_shutdown". > > What's weird (or looks weird) is that we stop the timer when requested > to switch to oneshot mode. But that's what we really wanted, because > set_next_event is the one that will program the timer in oneshot mode. Ok, thanks for the explanation. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
