On 2015/07/04 17:10, SF Markus Elfring wrote: > From: Markus Elfring <[email protected]> > Date: Sat, 4 Jul 2015 10:00:26 +0200 > > The module_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. >
OK, looks good to me. Acked-by: Masami Hiramatsu <[email protected]> > Signed-off-by: Markus Elfring <[email protected]> > --- > kernel/kprobes.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/kernel/kprobes.c b/kernel/kprobes.c > index c90e417..52e3529 100644 > --- a/kernel/kprobes.c > +++ b/kernel/kprobes.c > @@ -1531,10 +1531,7 @@ int register_kprobe(struct kprobe *p) > > out: > mutex_unlock(&kprobe_mutex); > - > - if (probed_mod) > - module_put(probed_mod); > - > + module_put(probed_mod); > return ret; > } > EXPORT_SYMBOL_GPL(register_kprobe); > -- Masami HIRAMATSU Linux Technology Research Center, System Productivity Research Dept. Center for Technology Innovation - Systems Engineering Hitachi, Ltd., Research & Development Group E-mail: [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
