On Tue, Jul 07, 2015 at 12:54:48AM +0530, Vaibhav Hiremath wrote: > From: Yipeng Yao <[email protected]> > > Fix below warning message, coming from 64 bit toolchain. > > drivers/i2c/busses/i2c-pxa.c:1237:15: warning: cast from pointer to integer > of different size [-Wpointer-to-int-cast] > > Signed-off-by: Yipeng Yao <[email protected]> > [[email protected]: Updated Changelog] > Signed-off-by: Vaibhav Hiremath <[email protected]> > Cc: Wolfram Sang <[email protected]> > Acked-by: Robert Jarzmik <[email protected]>
Huh? Why long? Shouldn't that be casted to enum pxa_i2c_types? > --- > drivers/i2c/busses/i2c-pxa.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c > index 632008f..4c92694 100644 > --- a/drivers/i2c/busses/i2c-pxa.c > +++ b/drivers/i2c/busses/i2c-pxa.c > @@ -1116,7 +1116,9 @@ static int i2c_pxa_probe_dt(struct platform_device > *pdev, struct pxa_i2c *i2c, > i2c->use_pio = 1; > if (of_get_property(np, "mrvl,i2c-fast-mode", NULL)) > i2c->fast_mode = 1; > - *i2c_types = (u32)(of_id->data); > + > + *i2c_types = (long)(of_id->data); > + > return 0; > } > > -- > 1.9.1 >
signature.asc
Description: Digital signature
