Chained irq handlers usually set up handler data as well. We now have
a function to set both under irq_desc->lock. Replace the two calls
with one.

Reported-by: Russell King <rmk+ker...@arm.linux.org.uk>
Signed-off-by: Thomas Gleixner <t...@linutronix.de>
Cc: Julia Lawall <julia.law...@lip6.fr>
Cc: Samuel Ortiz <sa...@linux.intel.com>
Cc: Lee Jones <lee.jo...@linaro.org>
---
 drivers/mfd/pm8921-core.c |    9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

Index: tip/drivers/mfd/pm8921-core.c
===================================================================
--- tip.orig/drivers/mfd/pm8921-core.c
+++ tip/drivers/mfd/pm8921-core.c
@@ -336,14 +336,12 @@ static int pm8921_probe(struct platform_
        if (!chip->irqdomain)
                return -ENODEV;
 
-       irq_set_handler_data(irq, chip);
-       irq_set_chained_handler(irq, pm8xxx_irq_handler);
+       irq_set_chained_handler_and_data(irq, pm8xxx_irq_handler, chip);
        irq_set_irq_wake(irq, 1);
 
        rc = of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev);
        if (rc) {
-               irq_set_chained_handler(irq, NULL);
-               irq_set_handler_data(irq, NULL);
+               irq_set_chained_handler_and_data(irq, NULL, NULL);
                irq_domain_remove(chip->irqdomain);
        }
 
@@ -362,8 +360,7 @@ static int pm8921_remove(struct platform
        struct pm_irq_chip *chip = platform_get_drvdata(pdev);
 
        device_for_each_child(&pdev->dev, NULL, pm8921_remove_child);
-       irq_set_chained_handler(irq, NULL);
-       irq_set_handler_data(irq, NULL);
+       irq_set_chained_handler_and_data(irq, NULL, NULL);
        irq_domain_remove(chip->irqdomain);
 
        return 0;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to