Hi Arnd, Thanks for your review. And can you give me more information? In my opinion, The fsl_edma_pm_state will just be used when CONFIG_PM support. So why not use the #ifdefs to remove the unnecessary code? Since the PM will not be selected in many use cases.
Thanks. Best Regards, Yuan Yao > -----Original Message----- > From: Arnd Bergmann [mailto:[email protected]] > Sent: Wednesday, July 15, 2015 5:57 PM > To: [email protected] > Cc: Yuan Yao-B46683; [email protected]; [email protected]; > [email protected]; [email protected]; linux- > [email protected] > Subject: Re: [PATCH] dmaengine: fsl-edma: add PM suspend/resume support > > On Wednesday 15 July 2015 17:32:58 Yuan Yao wrote: > > +#ifdef CONFIG_PM > > +enum fsl_edma_pm_state { > > + RUNNING = 0, > > + SUSPENDED, > > +}; > > +#endif > > > > struct fsl_edma_hw_tcd { > > > > The #ifdefs here seem unnecessary, at least most of them, better just do this > all unconditionally. > > Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
