On (07/16/15 09:10), Minchan Kim wrote: > There is no need to recalcurate pages_per_zspage in runtime. > Just use class->pages_per_zspage to avoid unnecessary runtime > overhead. > > * From v1 > * fix up __zs_compact - Sergey > > Signed-off-by: Minchan Kim <[email protected]>
thanks. Acked-by: Sergey Senozhatsky <[email protected]> -ss > --- > mm/zsmalloc.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index 27b9661c8fa6..c9685bb2bb92 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -1711,7 +1711,7 @@ static unsigned long zs_can_compact(struct size_class > *class) > obj_wasted /= get_maxobj_per_zspage(class->size, > class->pages_per_zspage); > > - return obj_wasted * get_pages_per_zspage(class->size); > + return obj_wasted * class->pages_per_zspage; > } > > static void __zs_compact(struct zs_pool *pool, struct size_class *class) > @@ -1749,8 +1749,7 @@ static void __zs_compact(struct zs_pool *pool, struct > size_class *class) > > putback_zspage(pool, class, dst_page); > if (putback_zspage(pool, class, src_page) == ZS_EMPTY) > - pool->stats.pages_compacted += > - get_pages_per_zspage(class->size); > + pool->stats.pages_compacted += class->pages_per_zspage; > spin_unlock(&class->lock); > cond_resched(); > spin_lock(&class->lock); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
