On Thu, 2015-07-16 at 18:21 +0200, Ahmed Mohamed Abd EL Mawgood wrote:
> This is my first patch to get my hand dirty
> 3 simple indentation errors fixing withen security/security.c
[]
> diff --git a/security/security.c b/security/security.c
[]
> @@ -567,8 +567,8 @@ int security_inode_rename(struct inode *old_dir, struct
> dentry *old_dentry,
> struct inode *new_dir, struct dentry *new_dentry,
> unsigned int flags)
> {
> - if (unlikely(IS_PRIVATE(d_backing_inode(old_dentry)) ||
> - (d_is_positive(new_dentry) &&
> IS_PRIVATE(d_backing_inode(new_dentry)))))
> + if (unlikely(IS_PRIVATE(d_backing_inode(old_dentry)) ||
> + (d_is_positive(new_dentry) && IS_PRIVATE(d_backing_inode(new_dentry)))))
> return 0;
See Documentation/CodingStyle, chapter 2:
Descendents are "substantially to the right", not aligned to the if
Some prefer alignment to open parentheses like:
if (unlikely(IS_PRIVATE(d_backing_inode(old_dentry)) ||
(d_is_positive(new_dentry) &&
IS_PRIVATE(d_backing_inode(new_dentry)))))
Others just want the indentation on a tab stop.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
