On Thu, Jul 16, 2015 at 04:26:07AM -0400, kan.li...@intel.com wrote:
> From: Kan Liang <kan.li...@intel.com>
>
> Introduce callgraph_set to indicate whether the callgraph option was set
> by user.
>
> Signed-off-by: Kan Liang <kan.li...@intel.com>
> ---
> tools/perf/builtin-record.c | 6 ++++--
> tools/perf/perf.h | 1 +
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 283fe96..1d40be9 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -762,12 +762,13 @@ static void callchain_debug(void)
> callchain_param.dump_size);
> }
>
> -int record_parse_callchain_opt(const struct option *opt __maybe_unused,
> +int record_parse_callchain_opt(const struct option *opt,
> const char *arg,
> int unset)
> {
> int ret;
>
> + *(bool *)opt->set = true;
> callchain_param.enabled = !unset;
>
> /* --no-call-graph */
> @@ -784,10 +785,11 @@ int record_parse_callchain_opt(const struct option *opt
> __maybe_unused,
> return ret;
> }
>
> -int record_callchain_opt(const struct option *opt __maybe_unused,
> +int record_callchain_opt(const struct option *opt,
> const char *arg __maybe_unused,
> int unset __maybe_unused)
> {
> + *(bool *)opt->set = true;
hum, how does this set callgraph_set ?
shouldn't it be 'callgraph_set = true' instead?
jirka
> callchain_param.enabled = true;
>
> if (callchain_param.record_mode == CALLCHAIN_NONE)
> diff --git a/tools/perf/perf.h b/tools/perf/perf.h
> index 937b16a..9ba02e0 100644
> --- a/tools/perf/perf.h
> +++ b/tools/perf/perf.h
> @@ -52,6 +52,7 @@ struct record_opts {
> bool sample_weight;
> bool sample_time;
> bool sample_time_set;
> + bool callgraph_set;
> bool period;
> bool sample_intr_regs;
> bool running_time;
> --
> 1.8.3.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
