On Sat, Jul 18, 2015 at 04:56:54PM +0200, Borislav Petkov wrote:
> On Fri, Jul 17, 2015 at 11:47:18AM -0500, Josh Poimboeuf wrote:
> > Add a C inline asm string version of the STACKVALIDATE_IGNORE_INSN macro
> > which tells stackvalidate to ignore the subsequent instruction.
> > 
> > Signed-off-by: Josh Poimboeuf <jpoim...@redhat.com>
> > ---
> >  arch/x86/include/asm/stackvalidate.h | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/arch/x86/include/asm/stackvalidate.h 
> > b/arch/x86/include/asm/stackvalidate.h
> > index 2d23c23..dac935c 100644
> > --- a/arch/x86/include/asm/stackvalidate.h
> > +++ b/arch/x86/include/asm/stackvalidate.h
> > @@ -23,6 +23,15 @@
> >     .endif
> >  .endm
> >  
> > +#else /* !__ASSEMBLY__ */
> > +
> 
> #ifdef CONFIG_STACK_VALIDATION
> 
> > +#define STACKVALIDATE_IGNORE_INSN                          \
> > +   ".Ltemp" __stringify(__LINE__) ":;"                     \
> > +   ".pushsection __stackvalidate_ignore_insn, \"a\";"      \
> > +   _ASM_ALIGN ";"                                          \
> > +   ".long .Ltemp" __stringify(__LINE__) " - .;"            \
> > +   ".popsection;"
> > +
> 
> #endif
> 
> 
> Also, you should end your lines with "\n" so that the .s output looks
> a bit more readable, not like now:
> 
> #APP
> # 30 "./arch/x86/include/asm/arch_hweight.h" 1
>         661:
>         .Ltemp32:;.pushsection __stackvalidate_ignore_insn, "a"; .balign 8 
> ;.long .Ltemp32 - .;.popsection;call __sw_hweight32
> 662:

Ok, will fix both issues.  Thanks.

-- 
Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to