On Tue, 21 Jul 2015 13:34:08 +0100 Graeme Gregory <[email protected]> wrote:
> On Tue, Jul 21, 2015 at 11:08:00AM +0100, Marc Zyngier wrote: > > Now that the basic ACPI GSI code is irq domain aware, make sure > > that the ACPI support in the GIC doesn't pointlessly deviate from > > the DT path. > > > > Signed-off-by: Marc Zyngier <[email protected]> > > --- > > drivers/irqchip/irq-gic.c | 17 ++++++----------- > > include/linux/irqchip/arm-gic.h | 2 +- > > 2 files changed, 7 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c > > index b41ccf5..f5d365d 100644 > > --- a/drivers/irqchip/irq-gic.c > > +++ b/drivers/irqchip/irq-gic.c > > @@ -813,8 +813,6 @@ static int gic_irq_domain_xlate(struct irq_domain *d, > > { > > unsigned long ret = 0; > > > > - if (irq_domain_get_of_node(d) != controller) > > - return -EINVAL; > This change seems to have nothing to do with the description. It has everything to do with making this function usable in the context of ACPI ;-). This is another ugly aspect of the irqdomain part, where "controller" is actually the device_node extracted from of_phandle_args. This will actually be the domain_token, and this comparison would fail with ACPI. I may add another patch for that. On DT, this is actually pretty useless, as we're always registering the GIC domain with its device_node, so this is really guaranteed to match. Thanks, M. -- Jazz is not dead. It just smells funny. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
