06b285bd1125 ("blkcg: fix blkcg_policy_data allocation bug")
introduced double unlock of blkcg_pol_mutx on allocation failure path.
Fix it.Signed-off-by: Tejun Heo <[email protected]> Reported-by: Dan Carpenter <[email protected]> Fixes: 06b285bd1125 ("blkcg: fix blkcg_policy_data allocation bug") --- block/blk-cgroup.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index 9da02c0..24fb729 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -1187,10 +1187,8 @@ int blkcg_policy_register(struct blkcg_policy *pol) struct blkcg_policy_data *cpd; cpd = kzalloc(pol->cpd_size, GFP_KERNEL); - if (!cpd) { - mutex_unlock(&blkcg_pol_mutex); + if (!cpd) goto err_free_cpds; - } blkcg->pd[pol->plid] = cpd; cpd->plid = pol->plid; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
