On Tue, Jul 21, 2015 at 05:08:42PM -0700, David Rientjes wrote:
> On Mon, 20 Jul 2015, Mel Gorman wrote:
>
> > From: Mel Gorman <[email protected]>
> >
> > File-backed pages that will be immediately dirtied are balanced between
> > zones but it's unnecessarily expensive. Move consider_zone_balanced into
> > the alloc_context instead of checking bitmaps multiple times.
> >
> > Signed-off-by: Mel Gorman <[email protected]>
>
> Acked-by: David Rientjes <[email protected]>
>
Thanks.
> consider_zone_dirty eliminates zones over their dirty limits and
> zone_dirty_ok() returns true if zones are under their dirty limits, so the
> naming of both are a little strange. You might consider changing them
> while you're here.
Yeah, that seems sensible. I named the struct field spread_dirty_page so
the relevant check now looks like
if (ac->spread_dirty_page && !zone_dirty_ok(zone))
Alternative suggestions welcome but I think this is more meaningful than
consider_zone_dirty was.
--
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
