Hi, Two very minor nits:
On Monday, July 27, 2015 10:32:38 AM Viresh Kumar wrote: > An opp can be shared by multiple devices, for example its very common > for CPUs to share the OPPs, i.e. when they share clock/voltage rails. > > This patch adds support of shared OPPs to the OPP library. > > Instead of a single device, dev_opp will not contain a list of devices s/will not/will now/ ? > that use it. It also senses if the device (we are trying to initialize > OPPs for) shares OPPs with a device added earlier and in that case we > update the list of devices managed by OPPs instead of duplicating OPPs > again. > > The same infrastructure will be used for the old OPP bindings, with > later patches. > > Reviewed-by: Stephen Boyd <[email protected]> > Signed-off-by: Viresh Kumar <[email protected]> [...] > +static struct device_list_opp *_add_list_dev(const struct device *dev, > + struct device_opp *dev_opp) > +{ > + struct device_list_opp *list_dev; > + > + list_dev = kzalloc(sizeof(*list_dev), GFP_KERNEL); > + if (!list_dev) > + return NULL; > + > + /* Initialize list-dev */ > + list_add_rcu(&list_dev->node, &dev_opp->dev_list); > + list_dev->dev = dev; Probably doesn't matter currently but how's about: list_dev->dev = dev; list_add_rcu(&list_dev->node, &dev_opp->dev_list); ? > + > + return list_dev; > +} Otherwise: Reviewed-by: Bartlomiej Zolnierkiewicz <[email protected]> Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
