On 27-07-15, 16:04, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <[email protected]> > > The leftover out_release_rwsem label in cpufreq_add_dev() is not > necessary any more and confusing, so drop it. > > Signed-off-by: Rafael J. Wysocki <[email protected]> > --- > drivers/cpufreq/cpufreq.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > Index: linux-pm/drivers/cpufreq/cpufreq.c > =================================================================== > --- linux-pm.orig/drivers/cpufreq/cpufreq.c > +++ linux-pm/drivers/cpufreq/cpufreq.c > @@ -1237,7 +1237,7 @@ static int cpufreq_add_dev(struct device > recover_policy = false; > policy = cpufreq_policy_alloc(dev); > if (!policy) > - goto out_release_rwsem; > + return -ENOMEM; > } > > cpumask_copy(policy->cpus, cpumask_of(cpu)); > @@ -1372,7 +1372,6 @@ out_exit_policy: > cpufreq_driver->exit(policy); > out_free_policy: > cpufreq_policy_free(policy, recover_policy); > -out_release_rwsem: > return ret;
There is no need to initialize ret to -ENOMEM now, please get rid of that as well and add my Acked-by: Viresh Kumar <[email protected]> -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

