On 29-07-15, 03:03, Rafael J. Wysocki wrote:
> +static int cpufreq_add_dev(struct device *dev, struct subsys_interface *sif)
> +{
> + unsigned cpu = dev->id;
> + int ret;
> +
> + dev_dbg(dev, "%s: adding CPU%u\n", __func__, cpu);
> +
> + if (cpu_online(cpu)) {
> + ret = cpufreq_online(cpu);
I will do return right here ...
> + } else {
... and this else will not be required anymore.
> + /*
> + * A hotplug notifier will follow and we will handle it as CPU
> + * online then. For now, just create the sysfs link, unless
> + * there is no policy or the link is already present.
> + */
> + struct cpufreq_policy *policy = per_cpu(cpufreq_cpu_data, cpu);
> +
> + ret = policy && !cpumask_test_and_set_cpu(cpu,
> policy->real_cpus)
> + ? add_cpu_dev_symlink(policy, cpu) : 0;
> + }
> +
> + return ret;
> +}
Looks good otherwise.
Acked-by: Viresh Kumar <viresh.ku...@linaro.org>
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
