On Thu, Jul 30, 2015 at 02:57:17PM +0300, Alexander Shishkin wrote:
> Peter Zijlstra <[email protected]> writes:
>
> > On Fri, Jul 17, 2015 at 04:34:08PM +0300, Alexander Shishkin wrote:
> >> +#define PT_CONFIG_MASK (RTIT_CTL_TSC_EN | \
> >> + RTIT_CTL_DISRETC | \
> >> + RTIT_CTL_CYCLEACC | \
> >> + RTIT_CTL_MTC_EN | \
> >> + RTIT_CTL_MTC_RANGE | \
> >> + RTIT_CTL_CYC_THRESH | \
> >> + RTIT_CTL_PSB_FREQ)
> >>
> >
> > #define RTIT_CTL_CYC (RTIT_CTL_CYCLEACC | \
> > RTIT_CTL_CYC_THRESH | \
> > RTIT_CTL_PSB_FREQ)
>
> PSB_FREQ is not, strictly speaking, related to cycle accurate mode. Both
> adjustable psb frequency and cycle accurate mode settings are enumerated
> with the same CPUID bit, but they really do different things unrelated
> to one another.
RTIT_CTL_CYC_PSB then, to match the CPUID bit name?
> >> + if (config & (RTIT_CTL_MTC_EN | RTIT_CTL_MTC_RANGE)) {
> >
> > if (config & RTIT_CTL_MTC) {
> >
> > Would that make sense?
>
> To me either way is fine. Want me to respin it?
Please.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
