On Tue, Jul 28, 2015 at 06:55:57PM +0800, [email protected] wrote: > Dear Johan： > Thank you for your reply me so quickly. > As you say, I have done the following test and verify: > 1.I have run scripts/checkpatch.pl on my patch,and test result is OK. > 2. I have installed this patch,and test result is OK. > 3.I have compiled the kernel code contains patch, and verified the > patch is correct. > 4.I have uninstall this patch,and test result is OK. > > The following is the new file attachment.If there anything is incorrect, > please let me know immediately,thank you.
Yes, please address the review comments below before resending in a format that can be applied (send the patch as an inline mail, not as a mime-attachment). And fix up the patch summary. > On Sat, Jul 25, 2015 at 10:53:22AM +0800, [email protected] wrote: > > Dear all： > > We want to add commit device's PID，we have been verified,the > > following is the content of the patch，If there anything is incorrect, > > please let me know immediately， thank you. > > Please read Documentation/SubmittingPatches for information on how to > format and submit a patch. > > Try sending the patch to yourself first and make sure to run > scripts/checkpatch.pl on it afterwards. > > For an example what such a patch may look like, see: > > > https://lkml.kernel.org/r/[email protected] > > > > diff -urN ./linux-4.1.2/drivers/usb/serial/option.c > > ./linux-4.1.2_plus/drivers/usb/serial/option.c > > --- ./linux-4.1.2/drivers/usb/serial/option.c 2015-07-10 > > 12:50:06.000000000 -0400 > > +++ ./linux-4.1.2_plus/drivers/usb/serial/option.c 2015-07-24 > > 21:10:02.075090212 -0400 > > @@ -285,6 +285,10 @@ > > #define ZTE_PRODUCT_MC2718 0xffe8 > > #define ZTE_PRODUCT_AD3812 0xffeb > > #define ZTE_PRODUCT_MC2716 0xffed > > +#define ZTE_PRODUCT_ZM8620_X 0x0396 > > +#define ZTE_PRODUCT_ME3620_X 0x1432 > > +#define ZTE_PRODUCT_ME3620_L 0x1433 > > +#define ZTE_PRODUCT_ME3620_MBIM 0x0426 > > Try to keep the entries ordered by PID. > > > #define BENQ_VENDOR_ID 0x04a5 > > #define BENQ_PRODUCT_H10 0x4068 > > @@ -544,6 +548,23 @@ > > .sendsetup = BIT(1) | BIT(2) | BIT(3), > > }; > > > > +static const struct option_blacklist_info zte_zm8620_x_blacklist = { > > + .reserved = BIT(3) | BIT(4) | BIT(5), > > +}; > > + > > +static const struct option_blacklist_info zte_me3620_x_blacklist = { > > + .reserved = BIT(3) | BIT(4) | BIT(5), > > +}; > > + > > +static const struct option_blacklist_info zte_me3620_l_blacklist = { > > + .reserved = BIT(3) | BIT(4) | BIT(5), > > +}; > > Could you reuse the same blacklist for related devices perhaps? > > > +static const struct option_blacklist_info zte_me3620_mbim_blacklist = { > > + .reserved = BIT(2) | BIT(3) | BIT(4), > > +}; > > And try to keep blacklist entries you add sorted by symbol name. > > > + > > + > > static const struct option_blacklist_info huawei_cdc12_blacklist = { > > .reserved = BIT(1) | BIT(2), > > }; > > @@ -1592,6 +1613,14 @@ > > { USB_VENDOR_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xff, 0x02, 0x01) > > > }, > > { USB_VENDOR_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xff, 0x02, 0x05) > > > }, > > { USB_VENDOR_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xff, 0x86, 0x10) > > > }, > > + { USB_DEVICE(ZTE_VENDOR_ID, ZTE_PRODUCT_ZM8620_X), > > + .driver_info = (kernel_ulong_t)&zte_zm8620_x_blacklist > }, > > + { USB_DEVICE(ZTE_VENDOR_ID, ZTE_PRODUCT_ME3620_X), > > + .driver_info = (kernel_ulong_t)&zte_me3620_x_blacklist > }, > > + { USB_DEVICE(ZTE_VENDOR_ID, ZTE_PRODUCT_ME3620_L), > > + .driver_info = (kernel_ulong_t)&zte_me3620_l_blacklist > }, > > + { USB_DEVICE(ZTE_VENDOR_ID, ZTE_PRODUCT_ME3620_MBIM), > > + .driver_info = > (kernel_ulong_t)&zte_me3620_mbim_blacklist > > }, > > Should be sorted by PID symbol whenever possible. > > > { USB_DEVICE(BENQ_VENDOR_ID, BENQ_PRODUCT_H10) }, > > { USB_DEVICE(DLINK_VENDOR_ID, DLINK_PRODUCT_DWM_652) }, > > > > > > > > > > 一一一一一一一一一一一一一一一一一一一一一一一 > > 胡滨 Hu Bin > > 产品研发一部 Product R&D Dept Ⅰ. > > > > Tel: +86-029-83636981 > > MP: +86-17792055220 > > Email: [email protected] > > Website: www.ztewelink.com > > Add: 西安市长安区西沣路五星段9号 1A3-56 > > -------------------------------------------------------- > > ZTE Information Security Notice: The information contained in this mail > (and any attachment transmitted herewith) is privileged and confidential > and is intended for the exclusive use of the addressee(s). If you are not > an intended recipient, any disclosure, reproduction, distribution or other > dissemination or use of the information contained is strictly prohibited. > If you have received this mail in error, please delete it and notify us > immediately. > > Please make sure not to include such headers when posting to public > mailing lists. > > Thanks, > Johan > > > -------------------------------------------------------- > ZTE Information Security Notice: The information contained in this mail (and > any attachment transmitted herewith) is privileged and confidential and is > intended for the exclusive use of the addressee(s). If you are not an > intended recipient, any disclosure, reproduction, distribution or other > dissemination or use of the information contained is strictly prohibited. If > you have received this mail in error, please delete it and notify us > immediately. Again, make sure to remove this header before reposting. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
