On Tuesday, August 04, 2015 04:01:59 PM David Daney wrote: > From: Tomasz Nowicki <[email protected]> > > Fixes the following build error when building drivers as modules: > > ERROR: "acpi_dev_prop_read_single" [drivers/net/phy/mdio-octeon.ko] > undefined! > ERROR: "acpi_dev_prop_read_single" > [drivers/net/ethernet/cavium/thunder/thunder_bgx.ko] undefined!
Can you please tell me why the drivers in question use that function directly, although they aren't supposed to? Clearly, their authors had not tried to build them as modules or they would have noticed the problem at the development stage already. What would be wrong with using the generic device properties API instead? > Reported-by: Andreas Schwab <[email protected]> > Signed-off-by: Tomasz Nowicki <[email protected]> > Signed-off-by: Robert Richter <[email protected]> > Signed-off-by: David Daney <[email protected]> > --- > drivers/acpi/property.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c > index 7836e2e..237e3c5 100644 > --- a/drivers/acpi/property.c > +++ b/drivers/acpi/property.c > @@ -432,6 +432,7 @@ int acpi_dev_prop_read_single(struct acpi_device *adev, > const char *propname, > } > return ret; > } > +EXPORT_SYMBOL_GPL(acpi_dev_prop_read_single); > > static int acpi_copy_property_array_u8(const union acpi_object *items, u8 > *val, > size_t nval) > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
