>
> AFAIK get_srcline() can return a string literal SRCLINE_UNKNOWN. It
> should not be freed or altered..
Good point. Here's a patch.
---
perf, tools: Check for SRCLINE_UNKNOWN case in srcline
Handle the SRCLINE_UNKNOWN case correctly when processing srcfile.
Pointed out by Namhyung.
Signed-off-by: Andi Kleen <[email protected]>
diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index c0c32b0..7e38716 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -330,6 +330,8 @@ static char *get_srcfile(struct hist_entry *e)
sf = get_srcline(map->dso, map__rip_2objdump(map, e->ip),
e->ms.sym, true);
+ if (!strcmp(sf, SRCLINE_UNKNOWN))
+ return no_srcfile;
p = strchr(sf, ':');
if (p && *sf) {
*p = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
