On Thu, Aug 13, 2015 at 05:17:05PM +0900, Chanwoo Choi wrote:
> "With commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get
> functions")
s/"//
> it becomes necessary to pass the flags argument. And this patch add the gpio
s/add/adds/
> header file to fix the build break when use random configuration file.
s/break/breakage/; s/use/build testing with/; s/file/files/
(That's at least what my German mind tells ...)
> Reported-by: Stephen Rothwell <[email protected]>
> Signed-off-by: Chanwoo Choi <[email protected]>
> ---
> drivers/extcon/extcon-palmas.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
> index 662e91778cb0..93c30a885740 100644
> --- a/drivers/extcon/extcon-palmas.c
> +++ b/drivers/extcon/extcon-palmas.c
> @@ -29,6 +29,7 @@
> #include <linux/of.h>
> #include <linux/of_platform.h>
> #include <linux/of_gpio.h>
> +#include <linux/gpio/consumer.h>
> #include <linux/workqueue.h>
>
> #define USB_GPIO_DEBOUNCE_MS 20 /* ms */
> @@ -208,7 +209,8 @@ static int palmas_usb_probe(struct platform_device *pdev)
> palmas_usb->wakeup = pdata->wakeup;
> }
>
> - palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
> + palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id",
> + GPIOD_IN);
This isn't aligned with the opening parenthesis in the line above. But
IIRC this isn't a hard requirement, so *shrug*.
Acked-by: Uwe Kleine-König <[email protected]>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
